Skip to content

Fix Issue 17806 - processAllocator getter will override set value if … #6413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Fix Issue 17806 - processAllocator getter will override set value if … #6413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b0b02e
Fix Issue 17806 - processAllocator getter will override set value if …
edi33416 Apr 3, 2018
8d070a5
Merge branch 'master' into fix_i17806
n8sh Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions std/experimental/allocator/package.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,18 @@ module std.experimental.allocator;
public import std.experimental.allocator.common,
std.experimental.allocator.typed;

// Fix issue 17806: this should always be the first unittest in this module
// in order to ensure that we use the `processAllocator` setter before the getter
@system unittest
{
import std.experimental.allocator.mallocator : Mallocator;
import std.experimental.allocator.gc_allocator : GCAllocator;
auto newAlloc = sharedAllocatorObject(Mallocator.instance);
processAllocator = newAlloc;
assert(processAllocator is newAlloc);
processAllocator = sharedAllocatorObject(GCAllocator.instance);
Copy link
Contributor

@wilzbach wilzbach Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not implicitly assume that it was the GCAllocator before and just reset it to the old value?

Copy link
Contributor Author

@edi33416 edi33416 Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require the setter to return the previous allocator, which it currently doesn't. In order to change the API to do this, we'd need to guard with a lock. We can regard this as a best effort.

Copy link
Member

@n8sh n8sh Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require the setter to return the previous allocator, which it currently doesn't.

That would also be a potential landmine since for basic types the result of (a = b) is the post-modification value of a, not the pre-modification value of a.

}

// Example in the synopsis above
@system unittest
{
Expand Down Expand Up @@ -1058,10 +1070,10 @@ allocator can be cast to `shared`.

/// Ditto
@nogc nothrow @system
@property void processAllocator(RCISharedAllocator a)
@property void processAllocator(ref RCISharedAllocator a)
{
assert(!a.isNull);
_processAllocator = a;
processAllocator() = a;
}

@system unittest
Expand Down