Added Params and Returns to std.functional #6454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @JackStouffer! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6454" |
JackStouffer
commented
Apr 16, 2018
| static int foo(ref int n) { return 2; } | ||
| } | ||
|
|
||
| // with forward |
Contributor
Author
There was a problem hiding this comment.
also made this example clearer
JackStouffer
force-pushed
the
functional-docs
branch
2 times, most recently
from
dbbb8f4 to
a05ab20
Compare
Contributor
Author
|
Same doc failure as other PRs |
n8sh
reviewed
Apr 17, 2018
std/functional.d
Outdated
| Params: | ||
| pred = A string or a callable | ||
| Returns: | ||
| A function which calls `pred` and returns its value negated. |
Member
There was a problem hiding this comment.
Although a predicate by definition is a function x => bool, it might be better to say "the logical negation of its value" instead of "its value negated".
JackStouffer
force-pushed
the
functional-docs
branch
from
a05ab20 to
626cabc
Compare
Contributor
Author
|
@n8sh Fixed |
Contributor
Author
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.