Skip to content

Return the actual symbols in the reversed range error #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Return the actual symbols in the reversed range error #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions regexp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,3 +1241,14 @@ func TestConcatAccidentalPatternCharge(t *testing.T) {
t.Fatal("Expected non-nil, got nil")
}
}

func TestGoodReverseOrderMessage(t *testing.T) {
_, err := Compile(`[h-c]`, ECMAScript)
if err == nil {
t.Fatal("expected error")
}
expected := "error parsing regexp: [h-c] range in reverse order in `[h-c]`"
if err.Error() != expected {
t.Fatalf("expected %q got %q", expected, err.Error())
}
}
4 changes: 2 additions & 2 deletions syntax/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ const (
ErrBadClassInCharRange = "cannot include class \\%v in character range"
ErrUnterminatedBracket = "unterminated [] set"
ErrSubtractionMustBeLast = "a subtraction must be the last element in a character class"
ErrReversedCharRange = "[x-y] range in reverse order"
ErrReversedCharRange = "[%c-%c] range in reverse order"
)

func (e ErrorCode) String() string {
Expand Down Expand Up @@ -1571,7 +1571,7 @@ func (p *parser) scanCharSet(caseInsensitive, scanOnly bool) (*CharSet, error) {
} else {
// a regular range, like a-z
if chPrev > ch {
return nil, p.getErr(ErrReversedCharRange)
return nil, p.getErr(ErrReversedCharRange, chPrev, ch)
}
cc.addRange(chPrev, ch)
}
Expand Down