Synoptic #128
Merged
Synoptic #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can load pages to itself based on it's name and the address parsing previously implemented. Plenty of work to do but a good start!
Could also happily delete all the Pages *.tsx files as we can now render them inside this
Other hooks such as useLocation are available and would allow us to quickly move forward with what we wanted to do
This reverts commit cfca2bf.
Turns out this line in App.css is very important, but we should definitely change it at some point ad put it in Widget.tsx or similar to make it clear what is happening and why it works
This was not really a problem before but meant that when the file or JSON did not change, the widget would not re render, which is not ideal when we would like to use the same page but fill it with different values Does not need to fetch file to perform this transformation, so this should be changed in the future, however this looks smoother for the time being so leaving in for demonstration purposes
This was referenced Dec 12, 2019
Closed
Menu Wrapper now has mocked useHistory() hook to allow tests to work as expected bobConversion checks if an incoming action has a description before trying to extract it Change in sim.ts to log instead of throw error on unhandled pv name has been reverted
Seems that this issue was actually caused byt eh updated macros continuously causing renders when not necessary and probably triggering unnecessary fetches. Have changed this logic now so that only a change in the file location will trigger a fetch. useEffect may still be necessary in the future if the fetch is expected to possibly take a long time.
This is an ongoing issue with shallow wrapping and the useEffect hook unfortunately! See enzymejs/enzyme#2011
Have decided to do this in conjunction with @willrogers as a stepping stone to a better solution
willrogers
reviewed
Dec 12, 2019
| if (history) { | ||
| closePage(action, history); | ||
| } else { | ||
| log.error("Tried to open a page but no history object passed"); |
|
Quite a few changes here but most of the important ones are quite likely to be revisited, so I'm happy to merge. Unfortunately Travis seems a bit busy right now. |
|
Yea I'm quite happy to fix some small changes if you have any more suggestions, otherwise we should probably make issues for the bigger issues and move on. Would be nice to wait for Travis to verify this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to create an approximation of the synoptic layout as used in CS-Studio and EDM, along with some other demonstrations such as a mobile friendly layout and performance page