Press by Numbers #10
Merged
Press by Numbers #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to pass a button number or iterate through them without having to explicitly cast to the enum type (XInputControl). The function will still take an enum value without complaint, this just makes it more flexible.
If the user uploads this without any joysticks connected, the inputs float and bounce all over the place. With these disabled by default, the user can upload this example to a bare board without any unexpected effects. Easy enough to flip the boolean and enable them if required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small pull request to change the button press/release/set functions to use an unsigned integer (
uint8_t) rather than an enumerated control as an argument.This lets the user press button numbers per their numbered listing in
joy.cplrather than using the enumerated values. It also lets them iterate through the button list without explicitly casting the enumeration as anXInputControl, which is easier to write. And since the control enumeration isn't scoped, this should cause no issues with passing enumerated values like normal.This pull request also disables joysticks by default in the
GamepadPinsexample, which means it will work properly on a bare Leonardo even if the user doesn't attach two joysticks to the analog pins.