Skip to content

Appease jshint warnings#269

Closed
arlolra wants to merge 1 commit intopegjs:masterfrom
arlolra:ctor
Closed

Appease jshint warnings#269
arlolra wants to merge 1 commit intopegjs:masterfrom
arlolra:ctor

Conversation

@arlolra
Copy link
Contributor

@arlolra arlolra commented May 20, 2014

It claims "a constructor name should start with an uppercase letter" and is concerned about a "possible strict violation" in the use of this.

@arlolra
Copy link
Contributor Author

arlolra commented May 20, 2014

The travis error says, "No compatible version found: minimatch@'^0.3.0'", which doesn't have anything to do with this patch.

wmfgerrit pushed a commit to wikimedia/mediawiki-services-parsoid that referenced this pull request May 21, 2014
 * Trying to upstream some of this:
   pegjs/pegjs#269

Change-Id: I62887bdbaa2230c8fdece2f619c7a836d5be9a31
@dmajda
Copy link
Contributor

dmajda commented May 30, 2014

I'm sorry but I can't reproduce the warning/error with make hint executed within PEG.js development environment as installed by npm install (this means JSHint 2.3.0 and configuration from .jshintrc).

I also tried the newest JSHint version (2.5.1) and the default configuration instead of the one in .jshintrc, but the result was the same.

What JSHint version & configuration did you use?

@arlolra
Copy link
Contributor Author

arlolra commented May 30, 2014

Sorry, I should have been clearer. The warnings were from my own jshintrc, which includes newcap and strict.

I updated the pull to add newcap to yours. I can do the same for strict if you're interested.

Thanks.

@dmajda
Copy link
Contributor

dmajda commented Apr 3, 2015

Re newcap: Sorry, I don’t think it makes sense to change conventions used in generated parser code just to appease JSHint. Moreover, as I just learned, the newcap option is deprecated and on its way out.

Re strict: No problem with this one in principle. Of course, the code needs to be converted first, which is tracked by #323 and #324.

Given that I won’t accept the newcap change I’m closing this. Any strict mode work should go into separate pull request(s).

And sorry I got back to this so late.

@dmajda dmajda closed this Apr 3, 2015
@arlolra arlolra deleted the ctor branch June 8, 2015 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants