Skip to content

Conversation

@olafnorge
Copy link

As it is possible to have the php-redis installed there is the need to distinguish which driver should be used. This is possible by reading the database.redis.client property from conf/database.php.

@coveralls
Copy link

coveralls commented Apr 18, 2017

Coverage Status

Coverage decreased (-8.3%) to 91.667% when pulling ff69e42 on olafnorge:support_predis_and_phpredis into 4962892 on dmitry-ivanov:master.

@coveralls
Copy link

coveralls commented Apr 18, 2017

Coverage Status

Coverage decreased (-8.3%) to 91.667% when pulling ff69e42 on olafnorge:support_predis_and_phpredis into 4962892 on dmitry-ivanov:master.

@olafnorge
Copy link
Author

Hi @dmitry-ivanov am I right assuming that you are taking my proposed changes by simply copy, pasting, slightly adjusting, committing, and pushing them to not having to appreciate my contribution?

@olafnorge olafnorge closed this Apr 19, 2017
@olafnorge olafnorge deleted the support_predis_and_phpredis branch April 19, 2017 14:40
@dmitry-ivanov
Copy link
Owner

@olafnorge Hi, I do appreciate your contribution, but there were some problems with your PR (code, and decreased code coverage). That's why it hadn't been merged.

Anyway, this feature is implemented and released in 1.4.5. And that's because of your help and contribution. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants