Skip to content

Conversation

@winkbrace
Copy link

@winkbrace winkbrace commented Mar 6, 2017

Give the unit tests TestCase a namespace, so it won't conflict with Laravel's TestCase.

By default in Laravel applications, the \TestCase class is provided as base test case for all unit tests.
The base \TestCase class in this libraries' unit test suite shows confliction errors in phpstorm, because the same class exists twice in the project.

By giving the base test case of this project a namespace, the conflict is resolved.

@coveralls
Copy link

coveralls commented Mar 6, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 7d5a3e3 on winkbrace:namespace-testcase into cc2b9a6 on dmitry-ivanov:master.

@dmitry-ivanov dmitry-ivanov merged commit 2835131 into dmitry-ivanov:master Mar 6, 2017
@dmitry-ivanov
Copy link
Owner

Thanks!

@winkbrace
Copy link
Author

Thank you too! 😃

@winkbrace winkbrace deleted the namespace-testcase branch March 7, 2017 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants