Skip to content

fix: add npm upgrade step for staged publishing #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theoephraim merged 1 commit into from
May 25, 2026
+13 −4
Merged

fix: add npm upgrade step for staged publishing #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .bumpy/npm-upgrade-step.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@varlock/bumpy': none
---

true
3 changes: 2 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ jobs:
with:
fetch-depth: 0
- uses: oven-sh/setup-bun@v2
# Node.js (npm) is needed for npm publish — latest includes npm >= 11.x for OIDC/staged
# Node.js (npm) is needed for npm publish
- uses: actions/setup-node@v6
with:
node-version: latest
- run: npm install -g npm@latest # ensure npm >= 11.15.0 for staged publishing
- run: bun install

# --- You wont need this part ---
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ jobs:
- uses: oven-sh/setup-bun@v2
- uses: actions/setup-node@v6
with:
node-version: latest # Node LTS ships with npm 10.x; latest includes npm >= 11.x for OIDC/staged
node-version: latest
- run: npm install -g npm@latest # ensure npm >= 11.15.0 for OIDC/staged publishing
- run: bun install
- run: bunx @varlock/bumpy ci release
env:
Expand Down
6 changes: 4 additions & 2 deletions docs/github-actions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

### Trusted publishing (OIDC — recommended)

No `NPM_TOKEN` secret needed. Use `node-version: latest` (not `lts/*`) since Node LTS ships with npm 10.x, while OIDC requires >= 11.5.1 and staged publishing requires >= 11.15.0.
No `NPM_TOKEN` secret needed. Requires npm >= 11.5.1 for OIDC (>= 11.15.0 for staged publishing) — add `npm install -g npm@latest` since even Node latest may not ship with a new enough npm.

```yaml
# .github/workflows/bumpy-release.yml
Expand All @@ -62,7 +62,8 @@ jobs:
- uses: oven-sh/setup-bun@v2
- uses: actions/setup-node@v6
with:
node-version: latest # Node LTS ships with npm 10.x; latest includes npm >= 11.x for OIDC/staged
node-version: latest
- run: npm install -g npm@latest # ensure npm >= 11.15.0 for OIDC/staged publishing
- run: bun install
- run: bunx @varlock/bumpy ci release
env:
Expand Down Expand Up @@ -157,6 +158,7 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: latest
- run: npm install -g npm@latest
- run: bun install

- id: plan
Expand Down