Skip to content

cloudflare: omit unsupported --keep-vars for wrangler versions upload #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theoephraim merged 3 commits into from
May 13, 2026
+15 −2
Merged

cloudflare: omit unsupported --keep-vars for wrangler versions upload #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a0288d
Initial plan
Copilot May 13, 2026
01b8c19
fix(cloudflare): skip keep-vars flag for versions upload
Copilot May 13, 2026
94f0453
fix(cloudflare): propagate wrangler exit code and remove extra test file
theoephraim May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .bumpy/fix-wrangler-keep-vars-flag.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@varlock/cloudflare-integration": patch
---

Fix varlock-wrangler: skip unsupported --keep-vars flag for `versions upload`, and propagate wrangler exit code correctly for deploy/types commands.
12 changes: 10 additions & 2 deletions packages/integrations/cloudflare/src/varlock-wrangler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,13 @@ function formatEnvFileContent(graph: ReturnType<typeof loadSerializedGraph>) {

// --- command detection ---

function isVersionsUploadCommand(args: Array<string>) {
return args[0] === 'versions' && args[1] === 'upload';
}

function isDeployCommand(args: Array<string>) {
if (args[0] === 'deploy') return true;
if (args[0] === 'versions' && args[1] === 'upload') return true;
if (isVersionsUploadCommand(args)) return true;
return false;
}

Expand Down Expand Up @@ -314,13 +318,16 @@ async function handleDeploy(args: Array<string>) {
let exitCode = process.exitCode ?? 0;
try {
debug('deploy: spawning wrangler');
exitCode = await spawnWrangler([...args, ...varFlags, '--secrets-file', tmp.filePath, '--keep-vars=false']);
const wranglerArgs = [...args, ...varFlags, '--secrets-file', tmp.filePath];
if (!isVersionsUploadCommand(args)) wranglerArgs.push('--keep-vars=false');
exitCode = await spawnWrangler(wranglerArgs);
debug('deploy: wrangler exited with code', exitCode);
} finally {
debug('deploy: cleaning up');
handle.stop();
tmp.cleanup();
}
process.exitCode = exitCode;
}

async function handleTypes(args: Array<string>) {
Expand Down Expand Up @@ -356,6 +363,7 @@ async function handleTypes(args: Array<string>) {
handle.stop();
tmp.cleanup();
}
process.exitCode = exitCode;
}

async function handleDev(args: Array<string>) {
Expand Down
Loading