Skip to content

Update analysis issues response domain model #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 8, 2019
Merged

Update analysis issues response domain model #20

merged 13 commits into from
Apr 8, 2019

Conversation

@cache-monet
Copy link
Contributor

@cache-monet cache-monet commented Apr 4, 2019 •
edited by dmuhs
Loading

GET analysis/${UUID}/issues returns an array of reported issues from different tools. Updated domain models to accommodate that.

Original DetectedIssueResponse is refactored into IssueReport.
New DetectedIssueResponse is an array that acts a container to the IssueReport objects

Fixes #17

@cache-monet cache-monet requested a review from dmuhs April 4, 2019 14:49
dmuhs
dmuhs approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@dmuhs dmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teamwork! 🎉

@dmuhs dmuhs merged commit d3162d1 into master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dmuhs dmuhs dmuhs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cache-monet cache-monet

Labels

Priority: Critical Status: Completed Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cache-monet @dmuhs