Add "SecurityOptions" in Info. #157
Conversation
types/types.go
Outdated
| ServerVersion string | ||
| ClusterStore string | ||
| ClusterAdvertise string | ||
| SecurityOptions string |
There was a problem hiding this comment.
should we make this a []string? I think that'd be better for the API (and similar to, e.g. how we have a list of installed plugins; https://github.com/docker/engine-api/blob/0ec73ff0299c6bc44426146a4ecaf5250536ea1c/types/types.go#L248-L257)
There was a problem hiding this comment.
@thaJeztah Yes []string is definitely better than a space separated string and easy to process. Let me update the pull request. Thanks!
This PR tries to add SecurityOptions field in Info so that security options such as apparmor, seccomp, or selinux could be displayed by `docker info`. Detailed discussion could be found in: moby/moby#20909 moby/moby#21172 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
@thaJeztah Just updated the pull request to change to |
|
LGTM |
1 similar comment
|
LGTM |
|
Please, do not merge this PR yet. We're waiting for a release cut in docker/docker before moving this forward. |
calavera
added
status/wait-until-release-freeze
and removed
status/wait-until-release-freeze
labels
|
We already have a tag a frozen branches for both projects. Merging this in 🎉 |
4 participants
This PR tries to add SecurityOptions field in Info so that security options such as apparmor, seccomp, or selinux could be displayed by
docker info.Detailed discussion could be found in:
moby/moby#20909
moby/moby#21172
cc @justincormack @calavera @thaJeztah
Signed-off-by: Yong Tang yong.tang.github@outlook.com