Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Conversation

@ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Sep 1, 2021

prepareVolumes MUST be ran before we retrieve a ServiceConfig reference otherwise the copy we get isn't up-to-date with volumes_from set to actual container

Related issue

#fix https://github.com/docker/compose-cli/issues/2035
also require compose-spec/compose-go#177

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof changed the title move compose-cli code into docker/compose/v2 update project's volumes_from before retrieving service Sep 1, 2021
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulyssessouza ulyssessouza merged commit 13dea3c into docker-archive:v2 Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants