Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Jan 5, 2017

Added a new test which is essentially a container version of the tutorial test. The test runs by starting the plugins as Docker containers and made sure that discovery works, CLI works, and we can go through the tutorial as the test scenario.

This test has been incorporated as part of the docker build. To run the test by itself:

scripts/container-test

Signed-off-by: David Chung david.chung@docker.com

dgageot and others added 3 commits January 5, 2017 09:51
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Chung <david.chung@docker.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "dockerfile-changes" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353348088
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@chungers chungers merged commit 531f964 into docker-archive:master Jan 6, 2017
@chungers chungers deleted the dockerfile-changes branch January 6, 2017 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants