Added powershell equivalents for start.sh and delete.sh #321
Conversation
|
Hi there - thanks for the PR and sorry for the delay in getting back. What would be the best way for the user to access these scripts? |
|
They can either run the script directly from powershell, or if you want an equivalent to the "Docker Quickstart Terminal" for powershell, you can create a windows shortcut with:
|
|
Got it, thanks! What's the advantage of this over calling the bash equivalents from Powershell? Is it that the user does not need to install Git Bash (which would make sense). Curious on the motives for this PR! Sorry for the late follow up |
jmorganca
force-pushed
the
master
branch
2 times, most recently
from
9cb5363 to
9927093
Compare
|
I was about to post an issue and/or PR for the same. I can't speak to the OP's motivation but I can offer one. I'm working on bundling Docker as part of a bundled application on Windows (in this case SageMath for Windows), and requiring Git + bash is just one more dependency / bit of overhead that seems unnecessary, and may only add further confusion to users who don't know what git is or why they need it. In fact, if Git is deselected in the Docker Toolbox install, it still installs the "Docker Quickstart Terminal" shortcut, which is broken if Git is not installed (whether through Toolbox or independently). I think for Windows the simpler approach is a native startup script rather than invoking an entire dependency that is not really technically needed given that If some version of this PR is accepted this doc page should also be updated: https://docs.docker.com/windows/step_one/ In particular step 2 which states that bash is required. |
|
(As far as this PR is concerned the delete script can also be dropped since the |
4 participants
No description provided.