This repository was archived by the owner on Sep 26, 2021. It is now read-only.
[Windows] add support for invoking quickstart from command-line, remove docker user-env variables on uninstall #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are variables that would have been permanently set during quick-start as per issue docker-archive#578 Signed-off-by: Somo S <somo@mombo.solutions>
This is so that the naming is consistent with that of `start.sh`. (as all `docker-terminal.cmd` is doing is pointing to `start.sh` in a more windows-centric way) Signed-off-by: Somo S <somo@mombo.solutions>
This was meant to have been included as part of commit c38f335 in pull-request docker-archive#578. But was not due to an oversight. Signed-off-by: Somo S <somo@mombo.solutions>
Contributor
Author
|
@shin- dispite the three commits this is a very simple PR. I have build and installed this updated version, and its working correctly on my end. Thank you again! |
Contributor
|
Thanks - changes LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an oversight, the
docker-terminal.cmdwas not being copied to the final windows program-files directory. This PR fixes this whilst also renamingdocker-terminal.cmdtodocker-start.cmd. So in windows, one can now simply type and rundocker-startfrom the terminal of their choice (powershell, cmd and git-bash), and this is now equivalent to clicking on the "Docker Quickstart Terminal" shortcut on the start menu.In addition,
this PR fixes a bug where docker environment variables were not being removed whenever docker-toolbox is being uninstalled.. So for example a user who is moving form docker-toolbox to docker for windows would have had to remove those set variables manually in their system settings. If they didn't know to do this, they'd wonder why docker for windows mysteriously doesn't work after docker-toolbox has been uninstalled