-
Couldn't load subscription status.
- Fork 1
Add format "int64" to HealthConfig #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'm going to double check for the upstream data type, maybe we (you? ;)) can ask them to fix their swagger definition as well.
Yes :-) I will file an issue There is already an issue: moby/moby#39131 |
Nice one :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@dvallant thanks a lot for your contribution! I'll try to cut a release soon, so that the fix will be available to you. |
|
@gesellix Thank you for the fast merge :-) After the new release of docker-remote-api I will make another pull request on docker-client to fix DeployConfigReader.groovy. |
|
A fresh release |
|
Submitted a fix for the swagger.yaml upstream: moby/moby#43629 |
Since the Docker API Specification defines the fields "interval", "timeout" and "start_period" for health checks as "nanoseconds" the correct data type should be Long.