[feature] Support for server v1.12 / api v1.24

[borlander]

Docker plugin for IntelliJ IDEs (https://plugins.jetbrains.com/plugin/7724) uses docker-java libraries for communication with docker remote API.

We are now receiving a lot of requests to support the new features available in server v1.12 (and remote API v1.24) and would like to understand what are your plans to support these versions.

[KostyaSha]

Feel free to PR features with test cases.

[KostyaSha]

Guys, please place +1 in emotion and subscribe if you want to get notifications about updates. Thanks.

[sevikkk]

Really we need bugfix for HostConfig first, and features as a second goal.

For now IntelliJ is plain broken with Docker for Mac beta16, as HostConfig on start is an error now, instead of warning.

[KostyaSha]

You still HAS ability to specify API version and it will continue working on existed feature set.
@borlander are you IDEA developer? Do you have some settings place?

[KostyaSha]

For docker-beta please follow references from #537 to netty issues to have native socket connection.

[borlander]

@KostyaSha Yes, we know how to specify API version and for me this is out of scope of this request.
And yes, we have already prepared netty + socat workaround.

For this request I would like to discuss exclusively the efforts required to support the features specific to the new server version.

[sevikkk]

With docker-for mac - it's separate issue from native connection - even with TCP port-forward it does not work, because of HostConfig issue.

[borlander]

@sevikkk https://youtrack.jetbrains.com/issue/IDEA-157736 will be fixed in the next plugin version.
No changes in the docker-java library is required for this one, so please lets discuss this issue in IntelliJ youtrack.

[KostyaSha]

Some thoughts here #619

[orzeh]

@KostyaSha Maybe I'm wrong but to fix HostConfig issue is just to change command to null in jaxrs/StartContainerCmdExec and netty/exec/StartContainerCmdExec?

[ceagan]

I'm running Docker for Windows 1.12.0-rc3-beta18 (build: 5226). I'm having trouble with the API version specification as the solution to this problem and I don't think that I can use the UNIX socket solution because this is on Windows.

If I specify API version 1.11, I see this error:

client version 1.11 is too old. Minimum supported API version is 1.12, please upgrade your client to a newer version

If I specify API version 1.12, I see this error:

{"message":"starting container with HostConfig was deprecated since v1.10 and removed in v1.12"}

From what I can tell, the Docker Daemon has pulled support for the last compatible API. Am I understanding that correctly?

I am using the docker-maven-plugin 2.11.15 from @alexec which depends on docker-java-orchestration 2.11.17 which depends on docker-java 3.0.0.

[KostyaSha]

API version != docker version.
https://docs.docker.com/engine/reference/api/docker_remote_api/
set it to 1.23

[ceagan]

This may be the wrong forum for this particular issue, but I think that since the code works with the Virtual Box version of Docker on Windows, that this might be an issue in docker-java.

I tried the setting you suggested and debugged the docker-maven-plugin to see what was happening. It turned out that I also had to set the versionAutoDetect property to false in order for this setting to have an effect. I then tried it with this configuration.

    <configuration>
        <host>tcp://localhost:2375</host>
        <version>1.23</version>
        <versionAutoDetect>false</versionAutoDetect>
    </configuration>

In debugging the code, this does appear to properly set the API version to 1.23, but results in a different error message. It seems like the API is returning an unexpected response.

[ERROR] Failed to execute goal com.alexecollins.docker:docker-maven-plugin:2.11.15:start (default) on project test: com.alexecollins.docker.orchestration.OrchestrationException: com.github.dockerjava.api.exception.InternalServerErrorException: EOF -> [Help 1]

For reference, when the version is set to 1.24, the following error appears.

[ERROR] Failed to execute goal com.alexecollins.docker:docker-maven-plugin:2.11.15:start (default) on project test: com.alexecollins.docker.orchestration.OrchestrationException: com.github.dockerjava.api.exception.BadRequestException: {"message":"starting container with HostConfig was deprecated since v1.10 and removed in v1.12"} -> [Help 1]

[KostyaSha]

[ERROR] Failed to execute goal com.alexecollins.docker:docker-maven-plugin:2.11.15:start (default) on project test: com.alexecollins.docker.orchestration.OrchestrationException: com.github.dockerjava.api.exception.InternalServerErrorException: EOF

#615