Skip to content

Conversation

@md5
Copy link
Contributor

@md5 md5 commented Feb 6, 2015

@md5 md5 changed the title Add documentation for WORDPRESS_DB_HOST Add documentation for WORDPRESS_DB_HOST Feb 6, 2015
@tianon tianon added the pending label Feb 6, 2015
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed there should probably be a comma at the end of this line (after "container"). Should I amend this commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@md5
Copy link
Contributor Author

md5 commented Feb 6, 2015

Updated to add a note about username and password.

@yosifkit
Copy link
Member

yosifkit commented Feb 6, 2015

LGTM

@tianon tianon added needsreview and removed pending labels Feb 6, 2015
@tianon
Copy link
Member

tianon commented Feb 6, 2015

LGTM, although we'll want to get a PR to the official-images repo open before we push this up 👍

tianon added a commit that referenced this pull request Feb 6, 2015
Add documentation for WORDPRESS_DB_HOST
@tianon tianon merged commit a3e4b5e into docker-library:master Feb 6, 2015
@tianon tianon removed the needsreview label Feb 6, 2015
@md5
Copy link
Contributor Author

md5 commented Feb 6, 2015

@tianon 📔 noted

@md5 md5 deleted the wordpress-external-db branch February 6, 2015 17:57
@tianon
Copy link
Member

tianon commented Feb 6, 2015 via email

@md5
Copy link
Contributor Author

md5 commented Feb 6, 2015

Sure. I was actually playing around with that last night for the Jetty image.

@md5
Copy link
Contributor Author

md5 commented Feb 6, 2015

Should it be showing docker-library/wordpress@dc184cf?

It looks like docker-library/wordpress@aac1d2e is the tip of master.

@md5
Copy link
Contributor Author

md5 commented Feb 6, 2015

It looks like git log -1 -- . doesn't include the merge commit because it didn't touch any files in ..

@md5
Copy link
Contributor Author

md5 commented Feb 6, 2015

Perhaps git show --format='format:%H' would be appropriate instead of git log -1 --format='format:%H' -- .?

@tianon
Copy link
Member

tianon commented Feb 6, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants