Problem With Login on Latest 5.1 Branch

[ctassell]

Hello,

I just pulled the latest 5.1 docker image last night and it seems to have broken the login page. On line 39 of app/controllers/account_controller.rb there is a line "no_store" and removing that seems to fix it. The error I was getting was:

, [2025-10-01T16:48:14.138489 #1]  INFO -- : [11fd7c68-09d3-49d6-a413-613f9a24c195] Processing by AccountController#login as HTML
I, [2025-10-01T16:48:14.138546 #1]  INFO -- : [11fd7c68-09d3-49d6-a413-613f9a24c195]   Parameters: {"back_url"=>"http://blah/"}
I, [2025-10-01T16:48:14.141531 #1]  INFO -- : [11fd7c68-09d3-49d6-a413-613f9a24c195]   Current user: anonymous
I, [2025-10-01T16:48:14.142084 #1]  INFO -- : [11fd7c68-09d3-49d6-a413-613f9a24c195] Completed 500 Internal Server Error in 3ms (ActiveRecord: 0.9ms | Allocations: 595)
F, [2025-10-01T16:48:14.142627 #1] FATAL -- : [11fd7c68-09d3-49d6-a413-613f9a24c195]   
[11fd7c68-09d3-49d6-a413-613f9a24c195] NameError (undefined local variable or method `no_store' for #<AccountController:0x000000003a6d80>):
[11fd7c68-09d3-49d6-a413-613f9a24c195]   
[11fd7c68-09d3-49d6-a413-613f9a24c195] app/controllers/account_controller.rb:39:in `login'
[11fd7c68-09d3-49d6-a413-613f9a24c195] lib/redmine/sudo_mode.rb:61:in `sudo_mode'

[yosifkit]

With a rough test I am unable to reproduce an issue. Can you provide any other clues or configuration that might point to a possible cause?

$ docker run -it --rm -p3000:3000 redmine:5.1
Unable to find image 'redmine:5.1' locally
5.1: Pulling from library/redmine
...
Digest: sha256:8eb648581de477292ade9eb195778ef3e6c9d8c7a380702b266d79adfec936c6
Status: Downloaded newer image for redmine:5.1
...
* Listening on http://0.0.0.0:3000
...
I, [2025-10-03T21:36:15.572982 #1]  INFO -- : [b74c49f6-2e59-425e-ad79-18c24bdf5aba] Processing by AccountController#login as HTML
I, [2025-10-03T21:36:15.573127 #1]  INFO -- : [b74c49f6-2e59-425e-ad79-18c24bdf5aba]   Parameters: {"utf8"=>"✓", "authenticity_token"=>"[...]", "back_url"=>"/", "username"=>"admin", "password"=>"[FILTERED]", "login"=>"Login"}
I, [2025-10-03T21:36:15.574458 #1]  INFO -- : [b74c49f6-2e59-425e-ad79-18c24bdf5aba]   Current user: anonymous
I, [2025-10-03T21:36:15.582513 #1]  INFO -- : [b74c49f6-2e59-425e-ad79-18c24bdf5aba] Successful authentication for 'admin' from 172.17.0.1 at 2025-10-03 21:36:15 UTC

[ctassell]

Sorry for the delay in getting back to you on this. We're running docker image d395c8ba73c6. The docker compose file is below, minus the env section which is just the DB settings. I'm wondering if it might be do to using an external mount for the config folder? Maybe there is a config setting which got migrated and we need to add into our local folder. We have some custom routes and had to patch database.yml to remove the quotes around "mysql2" in the adapter line.

We ran into the same issue again with another file today (users_controller.rb) Basically anytime the the "no_store" function gets called, the page crashes. Commenting out that line and restarting the container fixes the issue.

services:
redmine:
image: redmine:5.1
container_name: redmine
restart: always
tty: true
ports:
- 85:3000
volumes:
- type: bind
source: /usr/local/redmine/files
target: /usr/src/redmine/files
- type: bind
source: /usr/local/redmine/custom-plugins
target: /usr/src/redmine/plugins
- type: bind
source: /usr/local/redmine/config
target: /usr/src/redmine/config
- type: bind
source: /usr/local/redmine/roblib_redmine/
target: /usr/src/redmine/public/themes/roblib_redmine/

[panzli]

After upgrading our deployment from 5.1.9-bookworm to 5.1.10-bookworm the same error occurs.

I also think, that's a config needs to migrated.

[yosifkit]

I would guess that it is redmine/redmine@f816c78 that is failing to be applied to your instance because you are mounting the whole config directory and thus not getting the fix. The container files would be hidden by the mount. If you are going to replace the config/ directory, then you need to have the whole contents of it (and to update them at each container version bump):

$ docker run -it --rm redmine:5.1-bookworm bash
root@d95a7660949a:/usr/src/redmine# ls -l config/
additional_environment.rb.example  database.yml.example               locales/
application.rb                     environment.rb                     routes.rb
boot.rb                            environments/                      settings.yml
configuration.yml.example          initializers/
root@d95a7660949a:/usr/src/redmine# ls -l config/initializers/
total 32
-rw-rw-rw- 1 redmine redmine  375 Sep 21 10:15 00-core_plugins.rb
-rw-rw-rw- 1 redmine redmine 7151 Sep 21 10:15 10-patches.rb
-rw-rw-rw- 1 redmine redmine   82 Sep 21 10:15 20-mime_types.rb
-rw-rw-rw- 1 redmine redmine  959 Sep 21 10:15 30-redmine.rb
-rw-rw-rw- 1 redmine redmine  605 Sep 21 10:15 backtrace_silencers.rb
-rw-rw-rw- 1 redmine redmine  407 Sep 21 10:15 inflections.rb
-rw-rw-rw- 1 redmine redmine  727 Sep 21 10:15 zeitwerk.rb