Bake: support compose ssh config#2445
Bake: support compose ssh config#2445crazy-max merged 1 commit intodocker:masterfrom sumnerwarren:bake-compose-ssh
Conversation
|
Looking at the failed check: sorting for multiple ssh keys does not appear to be stable. Do we want bake to make it stable or should we just change to an |
|
@sumnerwarren Is it already coming unsorted from compose? In that case, it should be fixed in there. Meanwhile, we can just add some forced sorting in here to get this merged. |
|
@tonistiigi Yes, it's coming from compose unsorted, at least on macos. I ran I just pushed a commit that includes sorting. Note: I'm not a go expert, but I think it stems from using range on a map, which does not have a defined sort order. |
crazy-max
left a comment
There was a problem hiding this comment.
Thanks! Don't think we need a separate commit for sorting, can you squash commits please? Otherwise LGTM
Signed-off-by: Sumner Warren <sumner.warren@gmail.com>
Adds support for compose ssh config with bake. See spec. Based on #1069. This does not remove support for the
x-bakesshfield.