build: fix sharedkey computation for local context#2558
Merged
tonistiigi merged 1 commit intodocker:masterfrom Jun 28, 2024
Merged
build: fix sharedkey computation for local context#2558tonistiigi merged 1 commit intodocker:masterfrom
tonistiigi merged 1 commit intodocker:masterfrom
Conversation
When LocalDirs were changed to LocalMounts, this broke the sharedKey computation that was based on the context directory path. SharedKey defines if directory is valid candidate for incremental context transfer and if not set properly then different directories do metadata-based transfers to same destination. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2552
regression from #2254 (v0.14)
When LocalDirs were changed to LocalMounts, this broke the sharedKey computation that was based on the context directory path. SharedKey defines if directory is valid candidate for incremental context transfer and if not set properly then different directories do metadata-based transfers to same destination.