rm: reject context builders before loading nodes#3817
Merged
Conversation
tonistiigi
reviewed
Apr 23, 2026
Member
Author
There was a problem hiding this comment.
No, I don't think so. DockerContext is already set when we synthesize implicit context builders, and docker driver does not allow instances, so the post LoadNodes ContextName() check no longer covers a case that isn't already handled by the earlier one.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
7fb0900 to
2574d4c
Compare
tonistiigi
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current ordering is wrong for offline sockets. It forced driver detection and a daemon ping before rejecting a context-backed builder, which changed the user-facing error from the expected context removal guidance to an unrelated connection error:
The removal path now checks whether the selected builder came from a Docker context immediately after builder lookup and returns the existing
docker context rmguidance without callingLoadNodes.cc @fiam