This repository was archived by the owner on Oct 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[18.02] revert attach: Use ContainerWait instead of Inspect #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please sign your commits following these rules: $ git clone -b "qq" git@github.com:andrewhsu/docker-ce.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354562416
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
thaJeztah
approved these changes
Jan 31, 2018
Member
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for 18.02
Contributor
|
Given that it didn't occur until now, there may be a regression somewhere else 😇 |
Member
|
@mlaventure Yes, we should look into that; I discussed with @andrewhsu, and given that the issue it's fixing was already in previous releases, we deemed it was better to revert for this release, and look into the issue for the next release |
cpuguy83
pushed a commit
to cpuguy83/docker-ce
that referenced
this pull request
Feb 7, 2018
…t_test adding network list test Upstream-commit: ec99774a8521f461d7f4ddc75760ff33826cd3ad Component: cli
docker-jenkins
pushed a commit
that referenced
this pull request
Oct 23, 2019
…r_error [18.09 backport] Propagate GetContainer error from event processor Upstream-commit: 8f450df69ee9b181e217005bb6a4903db8cf3485 Component: engine
docker-jenkins
pushed a commit
that referenced
this pull request
Oct 30, 2019
unir: Remove old maintainers, add new ones Upstream-commit: 28a0f18 Component: packaging
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
unir: Remove old maintainers, add new ones
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert:
to address failures like:
reverting git commits 3acd490 1a65d7d:
only conflict on
cli/command/container/attach_test.gowhich i removed to resolve