Skip to content

Conversation

shin-
Copy link
Contributor

@shin- shin- commented Jun 16, 2017

Fixes #1639

Signed-off-by: Joffrey F <joffrey@docker.com>
@shin- shin- added this to the 2.4.0 milestone Jun 16, 2017
@shin- shin- merged commit 75e850e into docker:master Jun 19, 2017
@matthewtberry
Copy link
Contributor

@shin- connect_container_to_network() and disconnect_container_from_network() check 'image' as resource ID. Shouldn't these check 'container' instead?

@shin-
Copy link
Contributor Author

shin- commented Jun 29, 2017

@matthewtberry They certainly do. Can you create an issue / submit a PR? Thanks!

@matthewtberry
Copy link
Contributor

@shin- Yeah I can do both! Thanks.

@felixfontein
Copy link
Contributor

Actually, this fixes APIClient.inspect_node, which has been unusable from 1.10.0 on until 2.4.0 (when this fix has been first included) because it always errored with image or container param is undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants