2.4.0 release #1665
Merged
2.4.0 release #1665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to the multi-stage image building that was introduced in 17.05 (API 1.29). This allows a user to specify the stage of a multi-stage Dockerfile to build for, rather than the final stage. Signed-off-by: Yong Wen Chua <me@yongwen.xyz>
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Add `target` argument to image building
Signed-off-by: Joffrey F <joffrey@docker.com>
Add support for placement preferences and platforms in TaskTemplate
Signed-off-by: Alexey Rokhin <arokhin@mail.ru>
fix type checking for nano_cpus
Signed-off-by: allencloud <allen.sun@daocloud.io>
…tus-code-from-500-to-400 update node remove test status code from 500 to >= 400
…rect image_id depending on docer build output Signed-off-by: Chris Ottinger <chris.ottinger@team.telstra.com>
…fies that the build method uses the last success message for extracting the image id Signed-off-by: Chris Ottinger <chris.ottinger@team.telstra.com>
Signed-off-by: Chris Ottinger <chris.ottinger@team.telstra.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
In the case of a defined format with specific parts, a regular expression with named capturing bits make reasoning about the parts simpler than imlementing a parser from scratch. Signed-off-by: kaiyou <pierre@jaury.eu>
The test was copied from greybyte@ccec87c Signed-off-by: kaiyou <pierre@jaury.eu>
Signed-off-by: Madhuri Kumari <madhuri.kumari@intel.com>
The `from_env` method on the `docker` module passed `None` as the value for the `timeout` keyword argument which overrode the default value in the initialiser, taken from `constants` module. This sets the default in the initialiser to `None` and adds logic to set that, in the same way that `version` is handled. Signed-off-by: grahamlyons <graham@grahamlyons.com>
We'd like to be able to pass `None` as a value for `timeout` because it has meaning to the `requests` library (http://docs.python-requests.org/en/master/user/advanced/#timeouts) Signed-off-by: grahamlyons <graham@grahamlyons.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
The 2.18.0 version of requests breaks compatibility with docker-py: psf/requests#4160 [This block](https://github.com/shazow/urllib3/blob/master/urllib3/connectionpool.py#L292) of code from urllib3 fails: ```python def _get_timeout(self, timeout): """ Helper that always returns a :class:`urllib3.util.Timeout` """ if timeout is _Default: return self.timeout.clone() if isinstance(timeout, Timeout): return timeout.clone() else: # User passed us an int/float. This is for backwards compatibility, # can be removed later return Timeout.from_float(timeout) ``` In the case of requests version 2.18.0: `timeout` was an instance of `urllib3.util.timeout.Timeout` `Timeout` was an instance of `requests.packages.urllib3.util.timeout.Timeout` When the `isinstance(timeout, Timeout)` check fails the `urllib3.util.timeout.Timeout` object is passed as the `connection` argument to `requests.packages.urllib3.util.timeout.Timeout.from_float`. Signed-off-by: Matt Oberle <matt.r.oberle@gmail.com>
Only pull the 'latest' tag when testing images
excludes requests 2.18.0 from compatible versions
Signed-off-by: Joffrey F <joffrey@docker.com>
…er_stop Ensure default timeout is used by API Client
DockerClient.secrets should be a @Property
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Chris Mark <chrismarkou92@gmail.com>
This patch returns the check made against api when tagging an image as stated in documentation Signed-off-by: Olivier Sallou <olivier.sallou@irisa.fr>
Closes #1588, image.tag does not return anything
Raising error in case of invalid value of since kwarg on Container.logs
allow ipv6 :: notation in split_port (using re)
Add support for ``runtime`` config
Fix misleading build method docs
Add support for ingress in create_network
Signed-off-by: Joffrey F <joffrey@docker.com>
Update check_resource decorator to account for new resource names
Add support for start_period in Healthcheck spec
fix #1625 where ImageCollection.build() could return with incorrect image id
Signed-off-by: Joffrey F <joffrey@docker.com>
When using the multiprocessing module, it throws an AttributeError, complaining that the object does not have the attribute used. This adds the missing attributes and allows them to be pickled. Signed-off-by: An Ha <zero579911@gmail.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Make sure data is written in prune test so space can be reclaimed
Add network_mode support to Client.build
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Add attributes for pickling
Signed-off-by: Boik <qazbnm456@gmail.com>
…dns_opt_of_create_container Correct the description of dns_opt option of create_container
Support credHelpers section in config.json
Add support for ContainerSpec.TTY
Signed-off-by: Joffrey F <joffrey@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of PRs / issues for this release
Features
targetandnetwork_modeparameters inAPIClient.buildandDockerClient.images.build.runtimeparameter inAPIClient.create_containerand
DockerClient.containers.run.ingressparameter inAPIClient.create_networkandDockerClient.networks.create.placementconfiguration indocker.types.TaskTemplate.ttyconfiguration indocker.types.ContainerSpec.start_periodconfiguration indocker.types.Healthcheck.credHelperssection in Docker's configuration file is now recognized.Bugfixes
DockerClientusingdocker.from_envwouldn't correctly set the default timeout value.
DockerClient.secretswas not accessible as a property.DockerClient.buildwould sometimes return the wrongimage.
HostConfig.nano_cpusexceeding 2^32 wouldraise a type error.
Image.tagnow properly returnsTruewhen the operation is successful.APIClient.logsandContainer.logsnow raise an exception if thesinceargument uses an unsupported type instead of ignoring the value.
NullResourceexception whenthe resource ID was provided using a keyword argument.
Miscellaneous
APIClientinstances can now be pickled.