Fix service network regression on API < 1.25 #1859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
A user has reported to me that my change (b2d08e6#diff-627477fe9d783a0f4c5f8627948efbb1) has broken service network create/update on Docker version 1.12.
Below API level 1.25
Networkswas specified on theSpec, not on theTaskTemplate.This change moves the
Networkback toSpecbefore invoking the service create/update endpoints.Thanks!