Skip to content

Conversation

@thaJeztah
Copy link
Member

the "integration-dind-ssl" tests were failing due to an issue with the test-certs created;

==================================== ERRORS ====================================
_________ ERROR at setup of BuildTest.test_build_container_with_target _________
/usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:464: in _make_request
    self._validate_conn(conn)
/usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:1093: in _validate_conn
    conn.connect()
/usr/local/lib/python3.12/site-packages/urllib3/connection.py:790: in connect
    sock_and_verified = _ssl_wrap_socket_and_match_hostname(
/usr/local/lib/python3.12/site-packages/urllib3/connection.py:969: in _ssl_wrap_socket_and_match_hostname
    ssl_sock = ssl_wrap_socket(
/usr/local/lib/python3.12/site-packages/urllib3/util/ssl_.py:480: in ssl_wrap_socket
    ssl_sock = _ssl_wrap_socket_impl(sock, context, tls_in_tls, server_hostname)
/usr/local/lib/python3.12/site-packages/urllib3/util/ssl_.py:524: in _ssl_wrap_socket_impl
    return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
/usr/local/lib/python3.12/ssl.py:455: in wrap_socket
    return self.sslsocket_class._create(
/usr/local/lib/python3.12/ssl.py:1041: in _create
    self.do_handshake()
/usr/local/lib/python3.12/ssl.py:1319: in do_handshake
    self._sslobj.do_handshake()
E   ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: invalid CA certificate (_ssl.c:1010)

During handling of the above exception, another exception occurred:
/usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:787: in urlopen
    response = self._make_request(
/usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:488: in _make_request
    raise new_e
E   urllib3.exceptions.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: invalid CA certificate (_ssl.c:1010)

the "integration-dind-ssl" tests were failing due to an issue with the
test-certs created;

    ==================================== ERRORS ====================================
    _________ ERROR at setup of BuildTest.test_build_container_with_target _________
    /usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:464: in _make_request
        self._validate_conn(conn)
    /usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:1093: in _validate_conn
        conn.connect()
    /usr/local/lib/python3.12/site-packages/urllib3/connection.py:790: in connect
        sock_and_verified = _ssl_wrap_socket_and_match_hostname(
    /usr/local/lib/python3.12/site-packages/urllib3/connection.py:969: in _ssl_wrap_socket_and_match_hostname
        ssl_sock = ssl_wrap_socket(
    /usr/local/lib/python3.12/site-packages/urllib3/util/ssl_.py:480: in ssl_wrap_socket
        ssl_sock = _ssl_wrap_socket_impl(sock, context, tls_in_tls, server_hostname)
    /usr/local/lib/python3.12/site-packages/urllib3/util/ssl_.py:524: in _ssl_wrap_socket_impl
        return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
    /usr/local/lib/python3.12/ssl.py:455: in wrap_socket
        return self.sslsocket_class._create(
    /usr/local/lib/python3.12/ssl.py:1041: in _create
        self.do_handshake()
    /usr/local/lib/python3.12/ssl.py:1319: in do_handshake
        self._sslobj.do_handshake()
    E   ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: invalid CA certificate (_ssl.c:1010)

    During handling of the above exception, another exception occurred:
    /usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:787: in urlopen
        response = self._make_request(
    /usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:488: in _make_request
        raise new_e
    E   urllib3.exceptions.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: invalid CA certificate (_ssl.c:1010)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review October 14, 2025 21:08
@thaJeztah thaJeztah requested a review from Copilot October 14, 2025 21:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes SSL certificate generation issues in the integration test suite. The changes address certificate verification failures by properly configuring CA, server, and client certificates with correct X.509 v3 extensions and key usage attributes.

  • Adds proper v3_ca extension configuration for the Certificate Authority
  • Implements correct key usage and extended key usage for server certificates
  • Configures proper client authentication extensions for client certificates

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vvoland vvoland merged commit 824d3ab into docker:main Oct 14, 2025
11 checks passed
@thaJeztah thaJeztah deleted the fix_dind_ssl branch October 14, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants