This repository was archived by the owner on Sep 12, 2018. It is now read-only.
Use gevent to parallelize storage operations in get_tags#644
Merged
Conversation
Contributor
Author
|
Build failures appear unrelated? |
Contributor
|
Hello @bshi Build failure is a style issue.
You may want to run About this, it's too late for 0.9 unfortunately - so, I'll merge it after the release. |
Contributor
Author
|
Thanks; it was perhaps overly optimistic of me to skip installing the development environment. |
Contributor
|
It's pretty much |
This is a band-aid for #614 For context, hosted from a GCE instance with GCS being the backing store, With this patch, we are able to 'docker pull' 859 tags without a timeout. Prior to this patch, we were *unable* to pull anything from a repository with 200 tags. This is the extent of my investigation thus far. Unfortunately, this change is probably just a constant factor reduction in run-time as total network round-trips still grows linearly with tag count.
Contributor
|
0.9 is released - master is open for this. LGTM @stevvooe what do you think? |
Contributor
|
LGTM! |
Contributor
|
Merging for 1.0 |
dmp42
added a commit
that referenced
this pull request
Nov 6, 2014
Use gevent to parallelize storage operations in get_tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a band-aid for #614
For context, hosted from a GCE instance with GCS being the backing
store, With this patch, we are able to 'docker pull' 859 tags without a
timeout. Prior to this patch, we were unable to pull anything from a
repository with 200 tags. This is the extent of my investigation thus
far. Unfortunately, this change is probably just a constant factor
reduction in run-time as total network round-trips still grows linearly
with tag count.