Skip to content

Conversation

@arslannoorpansota
Copy link
Contributor

Proposed changes

Related issues (optional)

@netlify
Copy link

netlify bot commented Jul 30, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8de9a4e
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/62e57c360865f80009f7b18d
😎 Deploy Preview https://deploy-preview-15273--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@craig-osterhout
Copy link
Contributor

Thanks for aligning the text with the command. It should all probably be updated to the v2 syntax without the hyphen.
The PR checks are stuck. Closing and re-opening to see if it fixes it.

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to fix the consistency issue. As mentioned in previous comment, ideally should update all commands in the topic to newer syntax.

@craig-osterhout craig-osterhout merged commit ada4c68 into docker:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants