Replace docker/desktop-reclaim-space that doesn't work on Apple Silicon

[jmaitrehenry]

Proposed changes

I purpose to replace the docker/desktop-reclaim-space that doesn't work on Apple Silicon.
Instead of a custom build image, I use the nsenter image from justincormack and use the full command:

docker run -it --rm --privileged --pid=host justincormack/nsenter1 /sbin/fstrim -v /var/lib/docker

Related issues (optional)

Resolve samoshkin/docker-reclaim-disk-space#1

[netlify]

✅ Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	53baa47
🔍 Latest deploy log	https://app.netlify.com/sites/docsdocker/deploys/62fd4753e211ba00083b8cb6
😎 Deploy Preview	https://deploy-preview-15407--docsdocker.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[thaJeztah]

Thanks! We're having a discussion on this PR internally with @dvdksn, @jedevc 😅

Your change overall looks "correct" as a workaround; the instructions you added match what the docker/desktop-reclaim-space does, which looks to be built from the https://github.com/djs55/desktop-reclaim-space repository. That said; running the nsenter container is a bit more complicated, and makes it easier for users to (accidentally) run the wrong commands, which could potentially cause things to go wrong 😅.

There's a couple of things we were discussing (and perhaps @djs55 can help shedding some light);

• I know some improvements were made in the automatic trimming (see [POS-17] Add more docker event types to trigger fstrim linuxkit/linuxkit#3667, trim-after-delete: handle containers and volumes as well as images linuxkit/linuxkit#3539); @djs55 do you know if those changes are included in current Docker Desktop versions?
• ^^ 👆 if those are included, are the manual instructions still needed? Or do we know of cases where the automatic trimming is not enough? (can we fix those?)
• If we do still need those instructions;
  • should we consider moving the https://github.com/djs55/desktop-reclaim-space repository to the docker org?
  • .. and set it up with a docker-build-push action (https://github.com/docker/build-push-action) to make it mult-arch?

[docker-robott]

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

[thaJeztah]

This looks still relevant; or at least, the image is not yet multi-arch;

docker buildx imagetools inspect --raw docker/desktop-reclaim-space                                                                                             2464ms  Wed Feb 22 15:07:59 2023
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
   "config": {
      "mediaType": "application/vnd.docker.container.image.v1+json",
      "size": 1827,
      "digest": "sha256:acaa0a8bbb14452f1b229cf0a762c41050e6db8f7d0fd5c43bc2229b74c15a7d"
   },
   "layers": [
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 32021,
         "digest": "sha256:5bc638ae6f98f853c3e62a7b84c971cc7ceef4c6144b600c5b5ac7bf7cc72344"
      }
   ]
}⏎

[thaJeztah]

@djs55 could you have a look at this? Are these steps still needed for users, and if so, can we make the image multi-arch (and perhaps move the github repository)?

[riffraff]

this is still an issue a year and a half later