Skip to content

Conversation

@aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Oct 7, 2022

This PR adds no new content. It merely takes the content that was there and moves it to more intuitive places.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 1b14251
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6350fd3e80c2b4000907c628
😎 Deploy Preview https://deploy-preview-15826--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hyu
Copy link
Contributor

hyu commented Oct 19, 2022

After reviewing the Netlify preview and the current docs, I am so excited at the re-org in this PR! Here are the changes I observed:

  • Split the currently overwhelming Overview page into…
    • …a more welcoming, shorter page with cards to let users jump into the most relevant next steps
    • …and a "Key features and use cases" for the rest of the content
  • Consolidate Compose V2-related docs in its own section
  • Rename the generic "Getting started" (which may seem a bit redundant with Overview) to "Try Docker Compose," which is more of a crisp CTA and more accurate to the content on the page.

All these seem like excellent improvements. Let me know if I missed anything!

@hyu
Copy link
Contributor

hyu commented Oct 19, 2022

This is clearly beyond the scope of this PR, but I wanted to mention as feedback that I attempted to click these icons and was disappointed when they didn't work as part of the larger "button" (Only the blue link itself is clickable)

image

Not at all an actionable request for this PR, but leaving it here in context — in case it can contribute to a larger discussion around this component.

@aevesdocker
Copy link
Contributor Author

Thank you for going through it so closely! So pleased you approve of the changes.
Fixing the icon link is totally within this PR - in fact, it's something I should've done the first time around, but forgot 🤦 so fixing now!!

@aevesdocker aevesdocker marked this pull request as ready for review October 20, 2022 07:48
@aevesdocker aevesdocker requested review from dvdksn and usha-mandya and removed request for usha-mandya October 20, 2022 07:48
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good

star struck

@aevesdocker aevesdocker merged commit fb95c6b into docker:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants