Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Oct 11, 2022

Add stubs and config for fetching cache backend docs from upstream repo.

also fixed minor issue in the cache introduction doc (introduced by myself earlier)

@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6461a2a
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63467b5c10694c0009489d39
😎 Deploy Preview https://deploy-preview-15853--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jedevc
jedevc previously approved these changes Oct 11, 2022
Copy link
Contributor

@jedevc jedevc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me once rebased 😄

jedevc
jedevc previously approved these changes Oct 11, 2022
crazy-max
crazy-max previously approved these changes Oct 11, 2022
@crazy-max crazy-max dismissed their stale review October 11, 2022 10:20

htmlproofer not happy

@crazy-max
Copy link
Member

need to fix some links upstream: https://github.com/docker/docs/actions/runs/3225994881/jobs/5278977353#step:5:57

looks like we are using relative links:

- ./_site/build/building/cache-backends/index.html
  *  linking to internal hash #cache-from that does not exist (line 172)
     <a href="../../reference/buildx_build.md#cache-from"></a>
  *  linking to internal hash #cache-to that does not exist (line 170)
     <a href="../../reference/buildx_build.md#cache-to"></a>
  *  linking to internal hash #secret that does not exist (line 128)
     <a href="../../reference/buildx_build.md#secret">--secret</a>

@dvdksn
Copy link
Contributor Author

dvdksn commented Oct 11, 2022

Seems like changing from /cache-backends to /cache/backends broke some more relative links. Raised a PR to update the links in upstream: docker/buildx#1353

Signed-off-by: David Karlsson <david.karlsson@docker.com>
@dvdksn dvdksn requested review from aevesdocker and removed request for usha-mandya October 12, 2022 08:39
@dvdksn dvdksn merged commit b05c38a into docker:master Oct 12, 2022
@dvdksn dvdksn deleted the add-cache-docs branch October 12, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants