Skip to content

Conversation

@craig-osterhout
Copy link
Contributor

Proposed changes

Split create Dockerfile and add Dockerfile instructions into 2 steps.
Update Dockerfile description.
Add commands to create a Dockerfile.
Add tip to click Dockerfile instructions to learn more.

Related issues

Fixes #15934
Fixes #13855

@netlify
Copy link

netlify bot commented Oct 21, 2022

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit b610a27
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/635308775ba3de0008481540
😎 Deploy Preview https://deploy-preview-15944--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@craig-osterhout
Copy link
Contributor Author

@participator, thank you again for the feedback. Please take a look at the changes and let us know any if additional feedback.

@craig-osterhout craig-osterhout added the area/get-started Relates to get started and onboarding docs label Oct 21, 2022
Copy link
Contributor

@jerae-duffin jerae-duffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions. Otherwise, LGTM!

@jerae-duffin jerae-duffin self-requested a review October 21, 2022 21:07
Copy link
Contributor

@jerae-duffin jerae-duffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@craig-osterhout craig-osterhout merged commit f01d1bc into docker:master Oct 21, 2022
@participator
Copy link

participator commented Oct 21, 2022

@craig-osterhout Nice update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/get-started Relates to get started and onboarding docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows explorer show docker file Part 2 docker docs - Glosses over the Dockerfile lines

3 participants