Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Feb 1, 2024

  • test: add lint rules for tables
  • test: add lint rule for heading start
  • test: add lint rule for single h1
  • chore: unpublish README files in content dir
  • test: add lint rule for trailing punctuation in headings
  • test: add lint rule for empty links

Proposed changes

Related issues (optional)

Formatting for tables wasn't guarded by markdownlint validation rules,
which increases the risk of releasing incorrectly formatted tables.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Heading markup should start on the first column of a line, otherwise we
risk it being rendered as a paragraph, per the markdown spec.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
We should never have more than one h1 on a page.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Adds hugo build options that prevents these READMEs from being
published.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit dc379cf
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/65bbb2b865c4890008c2a162
😎 Deploy Preview https://deploy-preview-19285--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/compose Relates to docker-compose.yml spec or docker-compose binary area/build Relates to Dockerfiles or docker build command area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/cli Relates to the CLI client area/security area/configuration area/extensions Relates to Docker Extensions area/admin Relates to Docker Admin labels Feb 1, 2024
@dvdksn dvdksn requested a review from a team February 1, 2024 15:03
Copy link
Contributor

@stephaurelio stephaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dvdksn dvdksn merged commit 053ee9f into docker:main Feb 2, 2024
@dvdksn dvdksn deleted the markdownlint-add-more-rules branch February 2, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin Relates to Docker Admin area/build Relates to Dockerfiles or docker build command area/cli Relates to the CLI client area/compose Relates to docker-compose.yml spec or docker-compose binary area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/extensions Relates to Docker Extensions area/security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants