Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Feb 1, 2024

  • build: update flask version used in example
  • build: use exec form for flask example
  • fix: replace unsupported lang tags for dockerignore blocks
  • build: clarify that QEMU setup is only for non-desktop users
  • build: use a site param for example alpine versions

Proposed changes

Related issues (optional)

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested a review from crazy-max as a code owner February 1, 2024 17:03
@netlify
Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit ed1f51d
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/65c09822d350960008b4f65d
😎 Deploy Preview https://deploy-preview-19287--docsdocker.netlify.app/build/building/packaging
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/build Relates to Dockerfiles or docker build command hugo Updates related to hugo labels Feb 1, 2024
@dvdksn dvdksn requested a review from a team February 1, 2024 21:48
Copy link
Contributor

@stephaurelio stephaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM left one comment.

shell form doesnt trap sigint

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the build-building-freshness-tier2 branch from 58c62c9 to ed1f51d Compare February 5, 2024 08:11
@dvdksn dvdksn requested a review from stephaurelio February 5, 2024 08:11
Copy link
Contributor

@stephaurelio stephaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn dvdksn merged commit d685ae7 into docker:main Feb 5, 2024
@dvdksn dvdksn deleted the build-building-freshness-tier2 branch February 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command hugo Updates related to hugo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants