Compose Bridge early access #19702
Merged
Compose Bridge early access #19702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/compose
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
aevesdocker
reviewed
Apr 16, 2024
Contributor
aevesdocker
left a comment
aevesdocker
left a comment
There was a problem hiding this comment.
thank you @ndeloof and @glours. I've done a 'light' review (sorry for the number of comments)
I think this is fine for customer 0/EAP to get some initial feedback on Compose Bridge. I have lots of questions!
Could we also add to the top of each page the following callout (see example screenshot) with 'Compose Bridge is an early access product.'
I actually also think we should add this to the Table of contents with an early access badge.
| - A [Namespace](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/) so all your resources are isolated and don't colide with another deployment | ||
| - A [ConfigMap](https://kubernetes.io/docs/concepts/configuration/configmap/) with an entry for each and every config resource in your compose model | ||
| - [Deployment](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/)s for application services | ||
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports exposed by your services, used for service-to-service communication |
Contributor
There was a problem hiding this comment.
Suggested change
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports exposed by your services, used for service-to-service communication | |
| - [Services](https://kubernetes.io/docs/concepts/services-networking/service/) for ports exposed by your services, used for service-to-service communication |
| - A [ConfigMap](https://kubernetes.io/docs/concepts/configuration/configmap/) with an entry for each and every config resource in your compose model | ||
| - [Deployment](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/)s for application services | ||
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports exposed by your services, used for service-to-service communication | ||
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports published by your services, with type `LoadBalancer` so that Docker Desktop will also expose same port on host |
Contributor
There was a problem hiding this comment.
Suggested change
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports published by your services, with type `LoadBalancer` so that Docker Desktop will also expose same port on host | |
| - [Services](https://kubernetes.io/docs/concepts/services-networking/service/) for ports published by your services, with type `LoadBalancer` so that Docker Desktop will also expose same port on host |
| - [Deployment](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/)s for application services | ||
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports exposed by your services, used for service-to-service communication | ||
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports published by your services, with type `LoadBalancer` so that Docker Desktop will also expose same port on host | ||
| - [Network Policies](https://kubernetes.io/docs/concepts/services-networking/network-policies/) to replicate the networking topology expressed in compose |
Contributor
There was a problem hiding this comment.
Suggested change
| - [Network Policies](https://kubernetes.io/docs/concepts/services-networking/network-policies/) to replicate the networking topology expressed in compose | |
| - [Network policies](https://kubernetes.io/docs/concepts/services-networking/network-policies/) to replicate the networking topology expressed in Compose |
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports exposed by your services, used for service-to-service communication | ||
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports published by your services, with type `LoadBalancer` so that Docker Desktop will also expose same port on host | ||
| - [Network Policies](https://kubernetes.io/docs/concepts/services-networking/network-policies/) to replicate the networking topology expressed in compose | ||
| - [PersistentVolumeClaim](https://kubernetes.io/docs/concepts/storage/persistent-volumes/)s for your volumes, using `hostpath` storage class so that Docker Desktop manage volume creation |
Contributor
There was a problem hiding this comment.
Suggested change
| - [PersistentVolumeClaim](https://kubernetes.io/docs/concepts/storage/persistent-volumes/)s for your volumes, using `hostpath` storage class so that Docker Desktop manage volume creation | |
| - [PersistentVolumeClaims](https://kubernetes.io/docs/concepts/storage/persistent-volumes/) for your volumes, using `hostpath` storage class so that Docker Desktop manages volume creation |
| - [Service](https://kubernetes.io/docs/concepts/services-networking/service/)s for ports published by your services, with type `LoadBalancer` so that Docker Desktop will also expose same port on host | ||
| - [Network Policies](https://kubernetes.io/docs/concepts/services-networking/network-policies/) to replicate the networking topology expressed in compose | ||
| - [PersistentVolumeClaim](https://kubernetes.io/docs/concepts/storage/persistent-volumes/)s for your volumes, using `hostpath` storage class so that Docker Desktop manage volume creation | ||
| - [Secret](https://kubernetes.io/docs/concepts/configuration/secret/)s with your secret encoded - this is designed for local use in a testing environment |
Contributor
There was a problem hiding this comment.
Suggested change
| - [Secret](https://kubernetes.io/docs/concepts/configuration/secret/)s with your secret encoded - this is designed for local use in a testing environment | |
| - [Secrets](https://kubernetes.io/docs/concepts/configuration/secret/) with your secret encoded - this is designed for local use in a testing environment |
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Contributor
|
As discussed, merging now and will create follow-up PR to harmonize with docs |
aevesdocker
approved these changes
Apr 29, 2024
elegantcoder
pushed a commit
to elegantcoder/docs
that referenced
this pull request
Aug 28, 2024
* compose-bridge doc - release v0.0.1 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com> * Apply Ally's suggestions from first code review Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com> * manually adapt some review feedback Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com> --------- Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com> Co-authored-by: Guillaume Lours <705411+glours@users.noreply.github.com> Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compose Bridge documentation
Related issues or tickets
https://docker.atlassian.net/browse/COMP-505
Reviews