Skip to content

Conversation

@moleus
Copy link
Contributor

@moleus moleus commented Apr 2, 2024

Description

Enhances the documentation by incorporating two newly added parameters, requests.ephemeral-storage and limits.ephemeral-storage.

Related issues or tickets

issue: docker/buildx#2369
PR to docker/buildx: docker/buildx#2370

Reviews

  • Technical review
  • Editorial review
  • Product review

@moleus moleus requested review from crazy-max and dvdksn as code owners April 2, 2024 06:24
@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Apr 2, 2024
@netlify
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit a2fc415
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6626277b5c6195000840035a
😎 Deploy Preview https://deploy-preview-19726--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dvdksn
dvdksn previously approved these changes Apr 3, 2024
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn dvdksn added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Apr 3, 2024
@crazy-max crazy-max added this to the buildx v0.14.0 milestone Apr 15, 2024
crazy-max
crazy-max previously approved these changes Apr 15, 2024
@crazy-max crazy-max removed the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Apr 18, 2024
@dvdksn dvdksn dismissed stale reviews from crazy-max and themself via a2fc415 April 22, 2024 09:01
@dvdksn dvdksn force-pushed the feat-ephemeral-storage-opts branch from 64895f5 to a2fc415 Compare April 22, 2024 09:01
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased

@dvdksn dvdksn merged commit 8ce218f into docker:main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants