Skip to content

Conversation

@stephaurelio
Copy link
Contributor

@stephaurelio stephaurelio commented Apr 3, 2024

Description

Related issues or tickets

Closes JIRA https://docker.atlassian.net/browse/ENGDOCS-1996

Reviews

  • Technical review
  • Editorial review
  • Product review @ajthilakan

@github-actions github-actions bot added area/security hugo Updates related to hugo labels Apr 3, 2024
@netlify
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 04efe08
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6615b3460935e600099cbbd0
😎 Deploy Preview https://deploy-preview-19735--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stephaurelio stephaurelio marked this pull request as ready for review April 3, 2024 19:04
@stephaurelio stephaurelio requested a review from ajthilakan April 3, 2024 19:04
Copy link

@ajthilakan ajthilakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - reviewed & discussed some minor improvements, but I dont need to review those

@stephaurelio stephaurelio added the status/needs-more-info Need more information about the issue/PR label Apr 4, 2024
@stephaurelio stephaurelio removed the status/needs-more-info Need more information about the issue/PR label Apr 4, 2024
Copy link

@yarabarla yarabarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 🙌 . Just need to update that one diagram from the slack thread.

@stephaurelio stephaurelio requested a review from a team April 5, 2024 18:37

Docker uses the email address of the user to identify them on the platform. Every Docker account must have a unique email address at all times.

### SSO authentication with JIT provisioning enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make these two sections in to tabs instead? Save space on the page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see what you mean! For now I think we want the disabled info to be pretty prominent since this is a new change. Also wish we could link to specific tabs, because this content is linked from other sections. I am thinking of pulling this into a dedicated provisioning page once this goes to GA and simplify the Group Mapping page.

@stephaurelio stephaurelio requested a review from aevesdocker April 8, 2024 19:09
craig-osterhout
craig-osterhout previously approved these changes Apr 8, 2024
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephaurelio stephaurelio merged commit f1777ac into docker:main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security hugo Updates related to hugo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants