-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update provisioning references #19735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ajthilakan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - reviewed & discussed some minor improvements, but I dont need to review those
yarabarla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM 🙌 . Just need to update that one diagram from the slack thread.
|
|
||
| Docker uses the email address of the user to identify them on the platform. Every Docker account must have a unique email address at all times. | ||
|
|
||
| ### SSO authentication with JIT provisioning enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make these two sections in to tabs instead? Save space on the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what you mean! For now I think we want the disabled info to be pretty prominent since this is a new change. Also wish we could link to specific tabs, because this content is linked from other sections. I am thinking of pulling this into a dedicated provisioning page once this goes to GA and simplify the Group Mapping page.
craig-osterhout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds details about updating provisioning feature and its release phase
Improves heading and shortcode implementation
Adds new diagram describing the SSO provisioning flow
Complete your single sign-on connection
Manage users
Group mapping
Related issues or tickets
Closes JIRA https://docker.atlassian.net/browse/ENGDOCS-1996
Reviews