Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Apr 4, 2024

Description

Adds content categories in Docker Hub (labeled early access)

https://deploy-preview-19741--docsdocker.netlify.app/docker-hub/repos/categories/

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/hub Issue affects Docker Hub label Apr 4, 2024
@netlify
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 451b837
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66216cb714d8fc0008b849bf
😎 Deploy Preview https://deploy-preview-19741--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stephaurelio
Copy link
Contributor

@dvdksn I drafted some rough copy for potentially shifting towards category criteria vs definition here in Notion. Alternatively, I included some edited versions of the descriptions to tighten them up a bit. Hopefully those are a good starting point for updating the descriptions, but also happy to collaborate on any other edits.

@dvdksn dvdksn marked this pull request as ready for review April 17, 2024 14:21
@dvdksn dvdksn changed the title WIP: Docker Hub categories Docker Hub: add content categories Apr 17, 2024
Copy link

@chasefrankenfeld chasefrankenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@dvdksn dvdksn requested a review from a team April 18, 2024 14:36
Copy link
Contributor

@stephaurelio stephaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few editorial review comments. Nice work ✨

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested a review from stephaurelio April 18, 2024 18:55
Copy link
Contributor

@stephaurelio stephaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn dvdksn merged commit 91752dd into docker:main Apr 18, 2024
@dvdksn dvdksn deleted the hub-categories branch April 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hub Issue affects Docker Hub status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants