Skip to content

Conversation

@ajeetraina
Copy link
Contributor

This PR introduces a new collection of guides aimed at establishing a strong foundation in building the images. This initial set of guides focuses on:

  • Understanding the image layers
  • Writing a Dockerfile
  • Build, tag and publish an image
  • Multi-stage builds

@netlify
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit b8e94f8
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66262c321f0bcd00091f4f98
😎 Deploy Preview https://deploy-preview-19786--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is duplicating a lot of existing content. We already have a build guide. We already describe layers and cache and how they pertain to builds, and how multi-stage builds work.

Either we update the content that already exists, or we find a new angle that the existing content doesn't cover. We can't just pile on more of the same.

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ajeet. I added some suggestions for grammar and styles. I didn't look closely at the failing integration tests, but I think they're for the ordered list indentation. I tried to fix with suggestions if I noticed them, but I may have missed something.

In addition, it looks like there are some rogue files in the PR. Please help remove them. One is a .swp file and the other is an empty mulit-stage-builds.md file in the root.

ajeetraina and others added 22 commits April 17, 2024 08:59
…mage-layers.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…rfile.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…rfile.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md

Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
ajeetraina and others added 10 commits April 19, 2024 20:41
…-cache.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments.

I would like to raise as a general point, for future guides, that it's best if we avoid being too colloquial. (Use of exclamation marks, leading questions, or adjectives like "simple" and "easy".) I think it's great to be playful and witty, but we don't want to come across as eccentric, or worse: disrespectful.

ajeetraina and others added 14 commits April 22, 2024 14:14
…mage-layers.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…lds.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…lds.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…lds.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@ajeetraina
Copy link
Contributor Author

A few more comments.

I would like to raise as a general point, for future guides, that it's best if we avoid being too colloquial. (Use of exclamation marks, leading questions, or adjectives like "simple" and "easy".) I think it's great to be playful and witty, but we don't want to come across as eccentric, or worse: disrespectful.

Noted.

@craig-osterhout craig-osterhout merged commit 27350ce into docker:main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants