-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add documentation for core Docker concepts and guides #19786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is duplicating a lot of existing content. We already have a build guide. We already describe layers and cache and how they pertain to builds, and how multi-stage builds work.
Either we update the content that already exists, or we find a new angle that the existing content doesn't cover. We can't just pile on more of the same.
craig-osterhout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ajeet. I added some suggestions for grammar and styles. I didn't look closely at the failing integration tests, but I think they're for the ordered list indentation. I tried to fix with suggestions if I noticed them, but I may have missed something.
In addition, it looks like there are some rogue files in the PR. Please help remove them. One is a .swp file and the other is an empty mulit-stage-builds.md file in the root.
content/guides/docker-concepts/building-images/understanding-image-layers.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/understanding-image-layers.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/build-tag-and-publish-an-image.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/understanding-image-layers.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/understanding-image-layers.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/multi-stage-builds.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/multi-stage-builds.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/multi-stage-builds.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/multi-stage-builds.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/multi-stage-builds.md
Outdated
Show resolved
Hide resolved
…mage-layers.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…lds.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…mage-layers.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…rfile.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…rfile.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…ublish-an-image.md Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
…-cache.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…rfile.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments.
I would like to raise as a general point, for future guides, that it's best if we avoid being too colloquial. (Use of exclamation marks, leading questions, or adjectives like "simple" and "easy".) I think it's great to be playful and witty, but we don't want to come across as eccentric, or worse: disrespectful.
content/guides/docker-concepts/building-images/images/container_image_layer_reuse.svg
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/understanding-image-layers.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/understanding-image-layers.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/understanding-image-layers.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/understanding-image-layers.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/using-the-build-cache.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/multi-stage-builds.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/multi-stage-builds.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/understanding-image-layers.md
Outdated
Show resolved
Hide resolved
content/guides/docker-concepts/building-images/multi-stage-builds.md
Outdated
Show resolved
Hide resolved
…mage-layers.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…lds.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…lds.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…lds.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…mage-layers.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…-cache.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…r_image_layer_reuse.svg
Noted. |
This PR introduces a new collection of guides aimed at establishing a strong foundation in building the images. This initial set of guides focuses on: