build: experimental test instruction buildkit.exe #19792
Merged
+144
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/build
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@dvdksn There are a few instances where the command and the output are shown in the same code block. Should we separate them to make it easier for users to just copy the relevant commands? |
profnandaa
reviewed
Apr 12, 2024
Contributor
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
The rest LGTM, thanks!
dvdksn
force-pushed
the
buildkit-windows-exp
branch
from
50136dd to
b6f1bef
Compare
profnandaa
reviewed
Apr 15, 2024
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
buildkit-windows-exp
branch
from
b6f1bef to
2b13711
Compare
crazy-max
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add instruction for testing the experimental buildkit.exe support on Windows, with Buildx
Related issues or tickets
Carries moby/buildkit#4835
Reviews