scout: metrics exporter endpoint #19854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
felipecruz91
suggested changes
Apr 24, 2024
dvdksn
force-pushed
the
scout-prometheus-exporter
branch
from
4ef3e91 to
c365b52
Compare
Contributor
felipecruz91
left a comment
felipecruz91
left a comment
There was a problem hiding this comment.
Forgot to remove the honor_timestamps from the Prometheus config.
dvdksn
force-pushed
the
scout-prometheus-exporter
branch
from
c365b52 to
2dcb0f9
Compare
Contributor
felipecruz91
left a comment
felipecruz91
left a comment
There was a problem hiding this comment.
Some more minor comments.
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
scout-prometheus-exporter
branch
from
06ccdd9 to
42c4c51
Compare
felipecruz91
approved these changes
Apr 25, 2024
Contributor
felipecruz91
left a comment
felipecruz91
left a comment
There was a problem hiding this comment.
Great job David, it looks great!
aevesdocker
reviewed
Apr 29, 2024
Contributor
aevesdocker
left a comment
aevesdocker
left a comment
There was a problem hiding this comment.
LGTM, just some minor quibbles
| To view the Grafana dashboards, go to <http://localhost:3000/dashboards>, | ||
| and sign in using the credentials defined in the Docker Compose file (username: `admin`, password: `grafana`). | ||
|
|
||
|  |
Contributor
There was a problem hiding this comment.
Follow up PR to add this to our style guide?
Contributor
Author
There was a problem hiding this comment.
yeah I can add an example to the images page
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
scout-prometheus-exporter
branch
from
42c4c51 to
9e2ef18
Compare
aevesdocker
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preview
Adds documentation for the new metrics exporter API endpoint, which lets users use Prometheus to scrape Docker Scout metrics.
Related issues or tickets
Reviews