Skip to content

Conversation

@Pradumnasaraf
Copy link
Contributor

Description

  • Specify the type of secret needed to be created, as GitHub now has two kinds of secrets under Secrets and variables - Environment and Repository secret.
  • Add the missing command to commit the changes, etc in Run the following commands.. section.
  • Update the button text to "Test your deployment" to match the sidebar text (like other language docs).
  • Improve the context of a couple of sentences.

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/get-started Relates to get started and onboarding docs label Apr 24, 2024
@netlify
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 4c7f408
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6628d0bc5b87520008a01ceb
😎 Deploy Preview https://deploy-preview-19858--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn requested a review from craig-osterhout April 24, 2024 09:45
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@craig-osterhout craig-osterhout merged commit 5d209c7 into docker:main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/get-started Relates to get started and onboarding docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants