Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Apr 24, 2024

Description

  • Remove manual breakpoint definitions and use tailwind defaults
  • Fix various overflow and other rendering issues
  • Improve layout on medium size screens
  • Fix a js error where we incorrectly add an eventlistener for toc updates when there was no toc on page

Related issues

@dvdksn dvdksn requested a review from a team April 24, 2024 14:43
@github-actions github-actions bot added the hugo Updates related to hugo label Apr 24, 2024
@netlify
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit c27e60b
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66292fd00f8224000746cf5b
😎 Deploy Preview https://deploy-preview-19864--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn force-pushed the css-overflows-sizes branch 2 times, most recently from c21e7f4 to 5def43a Compare April 24, 2024 14:56
@github-actions github-actions bot added the area/get-started Relates to get started and onboarding docs label Apr 24, 2024
@dvdksn dvdksn force-pushed the css-overflows-sizes branch 2 times, most recently from 8d5ad42 to b69f0f3 Compare April 24, 2024 16:05
dvdksn added 3 commits April 24, 2024 18:14
- Remove manual breakpoint definitions and use tailwind defaults
- Fix various overflow and other rendering issues

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
- Keep the top-nav menu on medium screens
- Keep the sidebar navigation on medium screens
- Keep the right-hand toc on large screens
- Adjust breakpoints

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the css-overflows-sizes branch from e901304 to c27e60b Compare April 24, 2024 16:14
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I couldn't test 4k portrait, but the resizing I could test looks good.

@dvdksn dvdksn merged commit a94e438 into docker:main Apr 24, 2024
@dvdksn dvdksn deleted the css-overflows-sizes branch April 24, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/get-started Relates to get started and onboarding docs hugo Updates related to hugo status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long code spans overflow the page CLI reference table of contents renders incorrectly does not fit 4K portrait

2 participants