Skip to content

fix: prune double leading slash in favicon url #19874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: prune double leading slash in favicon url #19874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 static/assets/favicons/docs.ico → assets/favicons/docs.ico
View file
Open in desktop
File renamed without changes.
0 static/assets/favicons/docs@2x.ico → assets/favicons/docs@2x.ico
View file
Open in desktop
File renamed without changes.
6 changes: 1 addition & 5 deletions layouts/_default/engine-api-baseof.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@
content="Reference documentation and Swagger (OpenAPI) specification for the {{ .File.BaseFileName }} version of the API served by Docker Engine." />
<meta charset="utf-8" />
<!-- favicon -->
<meta name="msapplication-TileImage" content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" />
<meta property="og:image" content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" />
<link rel="apple-touch-icon" type="image/x-icon" href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
sizes="129x128" />
<link rel="icon" type="image/x-icon" href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" sizes="129x128" />
{{ partialCached "favicon.html" "favicon" }}
<!-- make the latest API version the canonical page as that's what we want users to be using mostly -->
<link rel="canonical" href="{{ site.BaseURL }}/engine/api/v{{ site.Params.latest_engine_api_version }}/" />
<style>
Expand Down
6 changes: 1 addition & 5 deletions layouts/_default/hub-api-baseof.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@
content="Reference documentation and Swagger (OpenAPI) specification for the {{ .File.BaseFileName }} API served by Docker Hub." />
<meta charset="utf-8" />
<!-- favicon -->
<meta name="msapplication-TileImage" content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" />
<meta property="og:image" content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" />
<link rel="apple-touch-icon" type="image/x-icon" href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
sizes="129x128" />
<link rel="icon" type="image/x-icon" href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" sizes="129x128" />
{{ partialCached "favicon.html" "favicon" }}
<!-- make the latest API version the canonical page as that's what we want users to be using mostly -->
<link rel="canonical" href="{{ site.BaseURL }}/docker-hub/api/latest/" />
<style>
Expand Down
17 changes: 17 additions & 0 deletions layouts/partials/favicon.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{{- $favicon := resources.Get "favicons/docs@2x.ico" }}
<link
rel="icon"
type="image/x-icon"
href="{{ $favicon.Permalink }}"
sizes="129x128"
/>
<link
rel="apple-touch-icon"
type="image/x-icon"
href="{{ $favicon.Permalink }}"
sizes="129x128"
/>
<meta
name="msapplication-TileImage"
content="{{ $favicon.Permalink }}"
/>
17 changes: 1 addition & 16 deletions layouts/partials/meta.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,7 @@
<link rel="canonical" href="{{ .Permalink }}" />

<!-- favicon -->
<link
rel="icon"
type="image/x-icon"
href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
sizes="129x128"
/>
<link
rel="apple-touch-icon"
type="image/x-icon"
href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
sizes="129x128"
/>
<meta
name="msapplication-TileImage"
content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
/>
{{ partialCached "favicon.html" "favicon" }}
<meta name="theme-color" content="#2496ed" />

<!-- SEO -->
Expand Down
Binary file removed static/assets/favicons/favicon.ico
View file
Open in desktop
Binary file not shown.