Skip to content

code rendering fixes #19877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2024
Merged

code rendering fixes #19877

merged 3 commits into from
Apr 25, 2024

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Apr 25, 2024 •
edited
Loading

Description

  • a: css: fix line wraps for code spans
  • b: css: apply basic styles to indented code blocks

before:

  • a: Screenshot 2024-04-25 at 15 23 50
  • b: Screenshot 2024-04-25 at 15 24 58

after:

  • a: Screenshot 2024-04-25 at 15 23 55
  • b: Screenshot 2024-04-25 at 15 38 33

Also fix sidebar width on small screens

Reviews

  • Technical review
  • Editorial review
  • Product review

dvdksn added 2 commits April 25, 2024 15:35
@dvdksn
css: fix line wraps for code spans
cbb8988 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn
css: apply basic styles to indented code blocks
28e23d9 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested a review from thaJeztah April 25, 2024 13:39
@github-actions github-actions bot added the hugo Updates related to hugo label Apr 25, 2024
@netlify
Copy link

netlify bot commented Apr 25, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 5f563c6
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/662a5fa4db60e70008ccaed1
😎 Deploy Preview https://deploy-preview-19877--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn
fix: sidebar-width sm screens
5f563c6 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
thaJeztah
thaJeztah approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lot better, thanks!

@dvdksn dvdksn merged commit 4241f60 into docker:main Apr 25, 2024
@dvdksn dvdksn deleted the fix-codespan-wrap branch April 25, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

hugo Updates related to hugo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dvdksn @thaJeztah