Skip to content

Add RAG Ollama application guide to the documentation #20395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 31 commits into from
Closed

Add RAG Ollama application guide to the documentation #20395

wants to merge 31 commits into from

Conversation

@mfranzon
Copy link
Contributor

@mfranzon mfranzon commented Jul 10, 2024

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9b28afb
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66d8710a38a946000824a9f1
😎 Deploy Preview https://deploy-preview-20395--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mfranzon mfranzon changed the title Add RAG Ollama application to the documentation Add RAG Ollama application guide to the documentation Jul 10, 2024
@craig-osterhout craig-osterhout requested a review from a team July 11, 2024 21:05
craig-osterhout
craig-osterhout requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfranzon, it's looking good.

You can update the data/toc.yaml so the topics appear in the table of contents. Also, you can update the use-case guides landing page at content/guides/use-case/_index.md to include this guide.

In general, it looks like your sample repo already has everything, so I suggest to avoid telling the user to create/add things because they might overwrite files or add duplicate instructions without realizing it's all already there.

mfranzon and others added 19 commits July 29, 2024 10:45
@mfranzon
add guide to _index and toc
fa2cb77
@mfranzon
Merge branch 'docker:main' into main
3138e15
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/_index.md
e4a0d77 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
8ab130a 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
9127fdb 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
a6e596a 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
43c013c 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
6f5a99d 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
5378dee 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
92bf895 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
f3c7cde 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
bd22b41 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
ad4757d 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
03926c0 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
36ea5d4 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
78e7b45 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
fe41f12 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon
add essentials
fc94aed
@mfranzon
add missing info about env variables
227551f
@mfranzon
Copy link
Contributor Author

mfranzon commented Aug 2, 2024

All the required changes are in place. Let me know if I had to change something else, thank you!

craig-osterhout
craig-osterhout requested changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mfranzon. Flow-wise, it looks good. Some of the spacing got misaligned and I added a few nit polish comments. Otherwise, LGTM.

@mfranzon @craig-osterhout
Update content/guides/use-case/_index.md
b0aca89 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
mfranzon and others added 9 commits September 4, 2024 16:32
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/containerize.md
43b9dd2 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/containerize.md
1d99c9c 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
f6e87d2 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/containerize.md
40c12cf 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/containerize.md
86147cf 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/develop.md
181c0c0 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/containerize.md
90d3357 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/containerize.md
b2ea91f 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon @craig-osterhout
Update content/guides/use-case/rag-ollama/containerize.md
9b28afb 
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
@mfranzon
Copy link
Contributor Author

mfranzon commented Sep 4, 2024

Thank you very much @craig-osterhout for the review and the refinement, I have committed all your suggestion. If you think it's ready to merge, I don't have anything to add.

@dvdksn dvdksn mentioned this pull request Sep 9, 2024
Merged
@dvdksn
Copy link
Contributor

dvdksn commented Sep 9, 2024

We recently did some restructuring in the docs repository. I've opened #20811 to carry this guide in, after rebasing and making the necessary updates as a result of the restructuring.

@dvdksn dvdksn closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craig-osterhout craig-osterhout Awaiting requested review from craig-osterhout

Assignees

No one assigned

Labels

status/review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfranzon @dvdksn @craig-osterhout