Skip to content

Conversation

@aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Sep 3, 2024

Description

Consolidates settings pages into one page

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/build Relates to Dockerfiles or docker build command area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/get-started Relates to get started and onboarding docs labels Sep 3, 2024
@netlify
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 2441b00
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66d700f0a37ea80008c02222
😎 Deploy Preview https://deploy-preview-20770--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the area/install Relates to installing a product label Sep 3, 2024
@aevesdocker aevesdocker marked this pull request as ready for review September 3, 2024 12:28
@aevesdocker aevesdocker requested a review from a team September 3, 2024 12:30
@dvdksn
Copy link
Contributor

dvdksn commented Sep 3, 2024

Is there a better way we can make these OS callouts? I find them hard to read in dark mode
image

Comment on lines -7 to -10
- /docker-for-mac/mutagen-caching/
- /docker-for-mac/mutagen/
- /docker-for-mac/osxfs-caching/
- /docker-for-mac/osxfs/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have some other place where we maintain these redirects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't, no, but these are at least 2 years old so in an effort to reduce the number of aliases we have I figured no one would miss them

@@ -1,7 +0,0 @@
Experimental features provide early access to future product functionality.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! interesting; thought we still would have this used somewhere, but maybe we don't 🤔

@aevesdocker
Copy link
Contributor Author

@dvdksn

Is there a better way we can make these OS callouts?

Could have just 'For windows/Mac only.' in the text but worry it will be missed. Maybe a green badge would be less jarring?

@dvdksn
Copy link
Contributor

dvdksn commented Sep 4, 2024

What about tables instead of lists?

@aevesdocker
Copy link
Contributor Author

Wouldn't that look weirder? Just the General section would need it

@aevesdocker aevesdocker mentioned this pull request Sep 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/engine Issue affects Docker engine/daemon area/get-started Relates to get started and onboarding docs area/install Relates to installing a product area/security status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants