Skip to content

Conversation

@sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Oct 1, 2024

Description

New PR for closed branch/PR, with relative path for URL.

Related issues or tickets

ENGDOCS-2239

Reviews

  • Editorial review

@netlify
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 656d6b1
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66fd9d96c08c5e000885dfcc
😎 Deploy Preview https://deploy-preview-21043--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

craig-osterhout
craig-osterhout previously approved these changes Oct 1, 2024
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Only nit is to change the link to a relative file link, but not a blocker.

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@sarahsanders-docker sarahsanders-docker merged commit c7d1495 into docker:main Oct 7, 2024
13 checks passed
@sarahsanders-docker sarahsanders-docker deleted the ENGDOCS-2239 branch October 7, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin Relates to Docker Admin status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants